view tests/with_hg.py @ 188:5609a21fe39a

client: fail gracefully on unexpected prompts (issue5516) Right now, if hglib encounters an unexpected prompt, it fails with a rather opaque "unexpected data on required channel 'L'" error message. Furthermore, if subsequently another command is called on the same client instance, both the client and server processes lock up hard (at least on Windows), and the server process rapidly leaks ~2GB of memory. Fix this by responding with an empty string to any unexpected prompt. This will trigger an "abort: response expected" exception from the server, which is easily handled as a CommandError, and subsequent commands sent from the same client work as expected. This doesn't completely resolve bug 5516, as unexpected requests on another required channel (e.g. I) can still cause a lockup. However, it does fix the most common case of an unexpected password prompt.
author G?bor Stefanik <gabor.stefanik@nng.com>
date Tue, 12 Sep 2017 13:16:36 -0400
parents f4f636ecca3e
children
line wrap: on
line source

import os
from nose.plugins import Plugin

class WithHgPlugin(Plugin):
    name = 'with-hg'
    enabled = False

    def options(self, parser, env):
        Plugin.options(self, parser, env)
        parser.add_option('--with-hg',
                          action='store',
                          type='string',
                          metavar='HG',
                          dest='with_hg',
                          help='test using specified hg script.')

    def configure(self, options, conf):
        Plugin.configure(self, options, conf)
        if options.with_hg:
            self.enabled = True
            self.hgpath = os.path.realpath(options.with_hg)

    def begin(self):
        import hglib

        p = hglib.util.popen([self.hgpath, 'version'])
        p.communicate()

        if p.returncode:
            raise ValueError("custom hg %r doesn't look like Mercurial"
                             % self.hgpath)

        hglib.HGPATH = self.hgpath