Mercurial > public > mercurial-scm > hg-stable
comparison contrib/check-code.py @ 18054:b35e3364f94a
check-code: there must also be whitespace between ')' and operator
The check pattern only checked for whitespace between keyword and operator.
Now it also warns:
> x = f(),7
missing whitespace after ,
> x = f()+7
missing whitespace in expression
| author | Mads Kiilerich <madski@unity3d.com> |
|---|---|
| date | Sun, 09 Dec 2012 23:33:16 +0100 |
| parents | fbe43efe4a53 |
| children | e440a2c0d944 |
comparison
equal
deleted
inserted
replaced
| 18053:0c2f0048125d | 18054:b35e3364f94a |
|---|---|
| 131 (r'\.has_key\b', "dict.has_key is not available in Python 3+"), | 131 (r'\.has_key\b', "dict.has_key is not available in Python 3+"), |
| 132 (r'^\s*\t', "don't use tabs"), | 132 (r'^\s*\t', "don't use tabs"), |
| 133 (r'\S;\s*\n', "semicolon"), | 133 (r'\S;\s*\n', "semicolon"), |
| 134 (r'[^_]_\("[^"]+"\s*%', "don't use % inside _()"), | 134 (r'[^_]_\("[^"]+"\s*%', "don't use % inside _()"), |
| 135 (r"[^_]_\('[^']+'\s*%", "don't use % inside _()"), | 135 (r"[^_]_\('[^']+'\s*%", "don't use % inside _()"), |
| 136 (r'\w,\w', "missing whitespace after ,"), | 136 (r'(\w|\)),\w', "missing whitespace after ,"), |
| 137 (r'\w[+/*\-<>]\w', "missing whitespace in expression"), | 137 (r'(\w|\))[+/*\-<>]\w', "missing whitespace in expression"), |
| 138 (r'^\s+\w+=\w+[^,)\n]$', "missing whitespace in assignment"), | 138 (r'^\s+\w+=\w+[^,)\n]$', "missing whitespace in assignment"), |
| 139 (r'(\s+)try:\n((?:\n|\1\s.*\n)+?)\1except.*?:\n' | 139 (r'(\s+)try:\n((?:\n|\1\s.*\n)+?)\1except.*?:\n' |
| 140 r'((?:\n|\1\s.*\n)+?)\1finally:', 'no try/except/finally in Python 2.4'), | 140 r'((?:\n|\1\s.*\n)+?)\1finally:', 'no try/except/finally in Python 2.4'), |
| 141 (r'(\s+)try:\n((?:\n|\1\s.*\n)*?)\1\s*yield\b.*?' | 141 (r'(\s+)try:\n((?:\n|\1\s.*\n)*?)\1\s*yield\b.*?' |
| 142 r'((?:\n|\1\s.*\n)+?)\1finally:', | 142 r'((?:\n|\1\s.*\n)+?)\1finally:', |