Mercurial > public > mercurial-scm > hg-stable
diff contrib/check-code.py @ 18054:b35e3364f94a
check-code: there must also be whitespace between ')' and operator
The check pattern only checked for whitespace between keyword and operator.
Now it also warns:
> x = f(),7
missing whitespace after ,
> x = f()+7
missing whitespace in expression
| author | Mads Kiilerich <madski@unity3d.com> |
|---|---|
| date | Sun, 09 Dec 2012 23:33:16 +0100 |
| parents | fbe43efe4a53 |
| children | e440a2c0d944 |
line wrap: on
line diff
--- a/contrib/check-code.py Sun Dec 09 23:33:16 2012 +0100 +++ b/contrib/check-code.py Sun Dec 09 23:33:16 2012 +0100 @@ -133,8 +133,8 @@ (r'\S;\s*\n', "semicolon"), (r'[^_]_\("[^"]+"\s*%', "don't use % inside _()"), (r"[^_]_\('[^']+'\s*%", "don't use % inside _()"), - (r'\w,\w', "missing whitespace after ,"), - (r'\w[+/*\-<>]\w', "missing whitespace in expression"), + (r'(\w|\)),\w', "missing whitespace after ,"), + (r'(\w|\))[+/*\-<>]\w', "missing whitespace in expression"), (r'^\s+\w+=\w+[^,)\n]$', "missing whitespace in assignment"), (r'(\s+)try:\n((?:\n|\1\s.*\n)+?)\1except.*?:\n' r'((?:\n|\1\s.*\n)+?)\1finally:', 'no try/except/finally in Python 2.4'),