Mercurial > public > mercurial-scm > hg-stable
comparison contrib/check-code.py @ 15282:d4addef0ec74
tests: don't use 'test -e'
On Solaris 10:
$ test -e f
test: argument expected
author | Mads Kiilerich <mads@kiilerich.com> |
---|---|
date | Mon, 17 Oct 2011 00:11:56 +0200 |
parents | 5a0fdc715769 |
children | ebeac9c41456 |
comparison
equal
deleted
inserted
replaced
15272:2889d4574726 | 15282:d4addef0ec74 |
---|---|
67 (r'^source\b', "don't use 'source', use '.'"), | 67 (r'^source\b', "don't use 'source', use '.'"), |
68 (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"), | 68 (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"), |
69 (r'ls\s+[^|-]+\s+-', "options to 'ls' must come before filenames"), | 69 (r'ls\s+[^|-]+\s+-', "options to 'ls' must come before filenames"), |
70 (r'[^>]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"), | 70 (r'[^>]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"), |
71 (r'stop\(\)', "don't use 'stop' as a shell function name"), | 71 (r'stop\(\)', "don't use 'stop' as a shell function name"), |
72 (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"), | |
72 ], | 73 ], |
73 # warnings | 74 # warnings |
74 [] | 75 [] |
75 ] | 76 ] |
76 | 77 |