Mercurial > public > mercurial-scm > hg-stable
diff contrib/check-code.py @ 15282:d4addef0ec74
tests: don't use 'test -e'
On Solaris 10:
$ test -e f
test: argument expected
author | Mads Kiilerich <mads@kiilerich.com> |
---|---|
date | Mon, 17 Oct 2011 00:11:56 +0200 |
parents | 5a0fdc715769 |
children | ebeac9c41456 |
line wrap: on
line diff
--- a/contrib/check-code.py Sat Oct 15 14:19:24 2011 -0500 +++ b/contrib/check-code.py Mon Oct 17 00:11:56 2011 +0200 @@ -69,6 +69,7 @@ (r'ls\s+[^|-]+\s+-', "options to 'ls' must come before filenames"), (r'[^>]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"), (r'stop\(\)', "don't use 'stop' as a shell function name"), + (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"), ], # warnings []