Mercurial > public > mercurial-scm > hg
annotate contrib/import-checker.py @ 24668:81873bb2a01d
import-checker: allow *.pyd based stdlib modules
These are Windows dlls, and eliminate the following import check diffs that are
not on Unix:
mercurial/changegroup.py mixed imports
stdlib: os, struct, tempfile, zlib
relative: bz2
mercurial/encoding.py mixed imports
stdlib: locale, os
relative: unicodedata
| author | Matt Harbison <matt_harbison@yahoo.com> |
|---|---|
| date | Wed, 08 Apr 2015 22:23:51 -0400 |
| parents | 784b278b349c |
| children | fbdbff1b486a |
| rev | line source |
|---|---|
| 20036 | 1 import ast |
| 2 import os | |
| 3 import sys | |
| 4 | |
|
20198
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
5 # Import a minimal set of stdlib modules needed for list_stdlib_modules() |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
6 # to work when run from a virtualenv. The modules were chosen empirically |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
7 # so that the return value matches the return value without virtualenv. |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
8 import BaseHTTPServer |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
9 import zlib |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
10 |
|
22975
461342e1c8aa
import-checker: check modules for pure Python build correctly
FUJIWARA Katsunori <foozy@lares.dti.ne.jp>
parents:
22974
diff
changeset
|
11 def dotted_name_of_path(path, trimpure=False): |
| 20036 | 12 """Given a relative path to a source file, return its dotted module name. |
| 13 | |
| 14 >>> dotted_name_of_path('mercurial/error.py') | |
| 15 'mercurial.error' | |
|
22975
461342e1c8aa
import-checker: check modules for pure Python build correctly
FUJIWARA Katsunori <foozy@lares.dti.ne.jp>
parents:
22974
diff
changeset
|
16 >>> dotted_name_of_path('mercurial/pure/parsers.py', trimpure=True) |
|
461342e1c8aa
import-checker: check modules for pure Python build correctly
FUJIWARA Katsunori <foozy@lares.dti.ne.jp>
parents:
22974
diff
changeset
|
17 'mercurial.parsers' |
|
20383
4990abb4729d
import-checker: fix names of dynamically loaded modules
Mads Kiilerich <madski@unity3d.com>
parents:
20238
diff
changeset
|
18 >>> dotted_name_of_path('zlibmodule.so') |
|
4990abb4729d
import-checker: fix names of dynamically loaded modules
Mads Kiilerich <madski@unity3d.com>
parents:
20238
diff
changeset
|
19 'zlib' |
| 20036 | 20 """ |
| 21 parts = path.split('/') | |
|
20391
466e4c574db0
import-checker: handle standard modules with arch in the filename
Mads Kiilerich <madski@unity3d.com>
parents:
20386
diff
changeset
|
22 parts[-1] = parts[-1].split('.', 1)[0] # remove .py and .so and .ARCH.so |
|
20383
4990abb4729d
import-checker: fix names of dynamically loaded modules
Mads Kiilerich <madski@unity3d.com>
parents:
20238
diff
changeset
|
23 if parts[-1].endswith('module'): |
|
4990abb4729d
import-checker: fix names of dynamically loaded modules
Mads Kiilerich <madski@unity3d.com>
parents:
20238
diff
changeset
|
24 parts[-1] = parts[-1][:-6] |
|
22975
461342e1c8aa
import-checker: check modules for pure Python build correctly
FUJIWARA Katsunori <foozy@lares.dti.ne.jp>
parents:
22974
diff
changeset
|
25 if trimpure: |
|
461342e1c8aa
import-checker: check modules for pure Python build correctly
FUJIWARA Katsunori <foozy@lares.dti.ne.jp>
parents:
22974
diff
changeset
|
26 return '.'.join(p for p in parts if p != 'pure') |
| 20036 | 27 return '.'.join(parts) |
| 28 | |
| 29 | |
| 30 def list_stdlib_modules(): | |
| 31 """List the modules present in the stdlib. | |
| 32 | |
| 33 >>> mods = set(list_stdlib_modules()) | |
| 34 >>> 'BaseHTTPServer' in mods | |
| 35 True | |
| 36 | |
| 37 os.path isn't really a module, so it's missing: | |
| 38 | |
| 39 >>> 'os.path' in mods | |
| 40 False | |
| 41 | |
| 42 sys requires special treatment, because it's baked into the | |
| 43 interpreter, but it should still appear: | |
| 44 | |
| 45 >>> 'sys' in mods | |
| 46 True | |
| 47 | |
| 48 >>> 'collections' in mods | |
| 49 True | |
| 50 | |
| 51 >>> 'cStringIO' in mods | |
| 52 True | |
| 53 """ | |
| 54 for m in sys.builtin_module_names: | |
| 55 yield m | |
| 56 # These modules only exist on windows, but we should always | |
| 57 # consider them stdlib. | |
| 58 for m in ['msvcrt', '_winreg']: | |
| 59 yield m | |
| 60 # These get missed too | |
| 61 for m in 'ctypes', 'email': | |
| 62 yield m | |
| 63 yield 'builtins' # python3 only | |
|
20197
761f2929a6ad
import-checker: refactor sys.path prefix check (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20038
diff
changeset
|
64 stdlib_prefixes = set([sys.prefix, sys.exec_prefix]) |
|
20198
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
65 # We need to supplement the list of prefixes for the search to work |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
66 # when run from within a virtualenv. |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
67 for mod in (BaseHTTPServer, zlib): |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
68 try: |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
69 # Not all module objects have a __file__ attribute. |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
70 filename = mod.__file__ |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
71 except AttributeError: |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
72 continue |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
73 dirname = os.path.dirname(filename) |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
74 for prefix in stdlib_prefixes: |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
75 if dirname.startswith(prefix): |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
76 # Then this directory is redundant. |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
77 break |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
78 else: |
|
f5393a9dc4e5
import-checker: make test-module-imports.t work using virtualenv (issue4129)
Chris Jerdonek <chris.jerdonek@gmail.com>
parents:
20197
diff
changeset
|
79 stdlib_prefixes.add(dirname) |
| 20036 | 80 for libpath in sys.path: |
|
20201
bc3b48b0f5c8
import-checker: suppress check-code about any()
Augie Fackler <raf@durin42.com>
parents:
20200
diff
changeset
|
81 # We want to walk everything in sys.path that starts with |
|
bc3b48b0f5c8
import-checker: suppress check-code about any()
Augie Fackler <raf@durin42.com>
parents:
20200
diff
changeset
|
82 # something in stdlib_prefixes. check-code suppressed because |
|
bc3b48b0f5c8
import-checker: suppress check-code about any()
Augie Fackler <raf@durin42.com>
parents:
20200
diff
changeset
|
83 # the ast module used by this script implies the availability |
|
bc3b48b0f5c8
import-checker: suppress check-code about any()
Augie Fackler <raf@durin42.com>
parents:
20200
diff
changeset
|
84 # of any(). |
|
20238
81e905790b30
check-code: do not skip entire file, skip only one match instead
Simon Heimberg <simohe@besonet.ch>
parents:
20201
diff
changeset
|
85 if not any(libpath.startswith(p) for p in stdlib_prefixes): # no-py24 |
| 20036 | 86 continue |
| 87 if 'site-packages' in libpath: | |
| 88 continue | |
| 89 for top, dirs, files in os.walk(libpath): | |
| 90 for name in files: | |
| 91 if name == '__init__.py': | |
| 92 continue | |
|
24668
81873bb2a01d
import-checker: allow *.pyd based stdlib modules
Matt Harbison <matt_harbison@yahoo.com>
parents:
24491
diff
changeset
|
93 if not (name.endswith('.py') or name.endswith('.so') |
|
81873bb2a01d
import-checker: allow *.pyd based stdlib modules
Matt Harbison <matt_harbison@yahoo.com>
parents:
24491
diff
changeset
|
94 or name.endswith('.pyd')): |
| 20036 | 95 continue |
| 96 full_path = os.path.join(top, name) | |
| 97 if 'site-packages' in full_path: | |
| 98 continue | |
| 99 rel_path = full_path[len(libpath) + 1:] | |
| 100 mod = dotted_name_of_path(rel_path) | |
| 101 yield mod | |
| 102 | |
| 103 stdlib_modules = set(list_stdlib_modules()) | |
| 104 | |
|
20037
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
105 def imported_modules(source, ignore_nested=False): |
| 20036 | 106 """Given the source of a file as a string, yield the names |
| 107 imported by that file. | |
| 108 | |
|
20037
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
109 Args: |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
110 source: The python source to examine as a string. |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
111 ignore_nested: If true, import statements that do not start in |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
112 column zero will be ignored. |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
113 |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
114 Returns: |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
115 A list of module names imported by the given source. |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
116 |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
117 >>> sorted(imported_modules( |
| 20036 | 118 ... 'import foo ; from baz import bar; import foo.qux')) |
|
20037
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
119 ['baz.bar', 'foo', 'foo.qux'] |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
120 >>> sorted(imported_modules( |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
121 ... '''import foo |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
122 ... def wat(): |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
123 ... import bar |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
124 ... ''', ignore_nested=True)) |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
125 ['foo'] |
| 20036 | 126 """ |
| 127 for node in ast.walk(ast.parse(source)): | |
|
20037
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
128 if ignore_nested and getattr(node, 'col_offset', 0) > 0: |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
129 continue |
| 20036 | 130 if isinstance(node, ast.Import): |
| 131 for n in node.names: | |
| 132 yield n.name | |
| 133 elif isinstance(node, ast.ImportFrom): | |
| 134 prefix = node.module + '.' | |
| 135 for n in node.names: | |
| 136 yield prefix + n.name | |
| 137 | |
| 138 def verify_stdlib_on_own_line(source): | |
| 139 """Given some python source, verify that stdlib imports are done | |
| 140 in separate statements from relative local module imports. | |
| 141 | |
| 142 Observing this limitation is important as it works around an | |
| 143 annoying lib2to3 bug in relative import rewrites: | |
| 144 http://bugs.python.org/issue19510. | |
| 145 | |
| 146 >>> list(verify_stdlib_on_own_line('import sys, foo')) | |
|
20386
a05d31b040d7
import-checker: show stdlib and relative imports separately
Mads Kiilerich <madski@unity3d.com>
parents:
20383
diff
changeset
|
147 ['mixed imports\\n stdlib: sys\\n relative: foo'] |
| 20036 | 148 >>> list(verify_stdlib_on_own_line('import sys, os')) |
| 149 [] | |
| 150 >>> list(verify_stdlib_on_own_line('import foo, bar')) | |
| 151 [] | |
| 152 """ | |
| 153 for node in ast.walk(ast.parse(source)): | |
| 154 if isinstance(node, ast.Import): | |
|
20386
a05d31b040d7
import-checker: show stdlib and relative imports separately
Mads Kiilerich <madski@unity3d.com>
parents:
20383
diff
changeset
|
155 from_stdlib = {False: [], True: []} |
| 20036 | 156 for n in node.names: |
|
20386
a05d31b040d7
import-checker: show stdlib and relative imports separately
Mads Kiilerich <madski@unity3d.com>
parents:
20383
diff
changeset
|
157 from_stdlib[n.name in stdlib_modules].append(n.name) |
|
a05d31b040d7
import-checker: show stdlib and relative imports separately
Mads Kiilerich <madski@unity3d.com>
parents:
20383
diff
changeset
|
158 if from_stdlib[True] and from_stdlib[False]: |
|
a05d31b040d7
import-checker: show stdlib and relative imports separately
Mads Kiilerich <madski@unity3d.com>
parents:
20383
diff
changeset
|
159 yield ('mixed imports\n stdlib: %s\n relative: %s' % |
|
a05d31b040d7
import-checker: show stdlib and relative imports separately
Mads Kiilerich <madski@unity3d.com>
parents:
20383
diff
changeset
|
160 (', '.join(sorted(from_stdlib[True])), |
|
a05d31b040d7
import-checker: show stdlib and relative imports separately
Mads Kiilerich <madski@unity3d.com>
parents:
20383
diff
changeset
|
161 ', '.join(sorted(from_stdlib[False])))) |
| 20036 | 162 |
| 163 class CircularImport(Exception): | |
| 164 pass | |
| 165 | |
|
24490
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
166 def checkmod(mod, imports): |
|
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
167 shortest = {} |
|
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
168 visit = [[mod]] |
|
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
169 while visit: |
|
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
170 path = visit.pop(0) |
|
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
171 for i in sorted(imports.get(path[-1], [])): |
|
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
172 if i not in stdlib_modules and not i.startswith('mercurial.'): |
|
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
173 i = mod.rsplit('.', 1)[0] + '.' + i |
|
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
174 if len(path) < shortest.get(i, 1000): |
|
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
175 shortest[i] = len(path) |
|
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
176 if i in path: |
|
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
177 if i == path[0]: |
|
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
178 raise CircularImport(path) |
|
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
179 continue |
|
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
180 visit.append(path + [i]) |
| 20036 | 181 |
|
20038
c65a6937b828
import-checker: try a little harder to show fewer cycles
Augie Fackler <raf@durin42.com>
parents:
20037
diff
changeset
|
182 def rotatecycle(cycle): |
|
c65a6937b828
import-checker: try a little harder to show fewer cycles
Augie Fackler <raf@durin42.com>
parents:
20037
diff
changeset
|
183 """arrange a cycle so that the lexicographically first module listed first |
|
c65a6937b828
import-checker: try a little harder to show fewer cycles
Augie Fackler <raf@durin42.com>
parents:
20037
diff
changeset
|
184 |
|
24488
4b3fc46097f7
import-checker: drop duplicate element from cycle
Matt Mackall <mpm@selenic.com>
parents:
24487
diff
changeset
|
185 >>> rotatecycle(['foo', 'bar']) |
|
20038
c65a6937b828
import-checker: try a little harder to show fewer cycles
Augie Fackler <raf@durin42.com>
parents:
20037
diff
changeset
|
186 ['bar', 'foo', 'bar'] |
|
c65a6937b828
import-checker: try a little harder to show fewer cycles
Augie Fackler <raf@durin42.com>
parents:
20037
diff
changeset
|
187 """ |
|
c65a6937b828
import-checker: try a little harder to show fewer cycles
Augie Fackler <raf@durin42.com>
parents:
20037
diff
changeset
|
188 lowest = min(cycle) |
|
c65a6937b828
import-checker: try a little harder to show fewer cycles
Augie Fackler <raf@durin42.com>
parents:
20037
diff
changeset
|
189 idx = cycle.index(lowest) |
|
24488
4b3fc46097f7
import-checker: drop duplicate element from cycle
Matt Mackall <mpm@selenic.com>
parents:
24487
diff
changeset
|
190 return cycle[idx:] + cycle[:idx] + [lowest] |
| 20036 | 191 |
| 192 def find_cycles(imports): | |
| 193 """Find cycles in an already-loaded import graph. | |
| 194 | |
| 195 >>> imports = {'top.foo': ['bar', 'os.path', 'qux'], | |
| 196 ... 'top.bar': ['baz', 'sys'], | |
| 197 ... 'top.baz': ['foo'], | |
| 198 ... 'top.qux': ['foo']} | |
| 199 >>> print '\\n'.join(sorted(find_cycles(imports))) | |
|
24487
642d245ff537
import-checker: fix rotatecycle
Matt Mackall <mpm@selenic.com>
parents:
22975
diff
changeset
|
200 top.bar -> top.baz -> top.foo -> top.bar |
|
642d245ff537
import-checker: fix rotatecycle
Matt Mackall <mpm@selenic.com>
parents:
22975
diff
changeset
|
201 top.foo -> top.qux -> top.foo |
| 20036 | 202 """ |
|
24491
784b278b349c
import-checker: rotatecycle is actually the canonical cycle key
Matt Mackall <mpm@selenic.com>
parents:
24490
diff
changeset
|
203 cycles = set() |
| 20036 | 204 for mod in sorted(imports.iterkeys()): |
| 205 try: | |
|
24490
fb4639d5268e
import-checker: make search algorithm non-recursive breadth-first
Matt Mackall <mpm@selenic.com>
parents:
24489
diff
changeset
|
206 checkmod(mod, imports) |
| 20036 | 207 except CircularImport, e: |
| 208 cycle = e.args[0] | |
|
24491
784b278b349c
import-checker: rotatecycle is actually the canonical cycle key
Matt Mackall <mpm@selenic.com>
parents:
24490
diff
changeset
|
209 cycles.add(" -> ".join(rotatecycle(cycle))) |
|
784b278b349c
import-checker: rotatecycle is actually the canonical cycle key
Matt Mackall <mpm@selenic.com>
parents:
24490
diff
changeset
|
210 return cycles |
| 20036 | 211 |
| 212 def _cycle_sortkey(c): | |
| 213 return len(c), c | |
| 214 | |
| 215 def main(argv): | |
| 216 if len(argv) < 2: | |
| 217 print 'Usage: %s file [file] [file] ...' | |
| 218 return 1 | |
| 219 used_imports = {} | |
| 220 any_errors = False | |
| 221 for source_path in argv[1:]: | |
| 222 f = open(source_path) | |
|
22975
461342e1c8aa
import-checker: check modules for pure Python build correctly
FUJIWARA Katsunori <foozy@lares.dti.ne.jp>
parents:
22974
diff
changeset
|
223 modname = dotted_name_of_path(source_path, trimpure=True) |
| 20036 | 224 src = f.read() |
|
20037
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
225 used_imports[modname] = sorted( |
|
957b43371928
import-checker: ignore nested imports
Augie Fackler <raf@durin42.com>
parents:
20036
diff
changeset
|
226 imported_modules(src, ignore_nested=True)) |
| 20036 | 227 for error in verify_stdlib_on_own_line(src): |
| 228 any_errors = True | |
| 229 print source_path, error | |
| 230 f.close() | |
| 231 cycles = find_cycles(used_imports) | |
| 232 if cycles: | |
| 233 firstmods = set() | |
| 234 for c in sorted(cycles, key=_cycle_sortkey): | |
| 235 first = c.split()[0] | |
| 236 # As a rough cut, ignore any cycle that starts with the | |
| 237 # same module as some other cycle. Otherwise we see lots | |
| 238 # of cycles that are effectively duplicates. | |
| 239 if first in firstmods: | |
| 240 continue | |
| 241 print 'Import cycle:', c | |
| 242 firstmods.add(first) | |
| 243 any_errors = True | |
| 244 return not any_errors | |
| 245 | |
| 246 if __name__ == '__main__': | |
| 247 sys.exit(int(main(sys.argv))) |