lfs: add basic routing for the server side wire protocol processing The recent hgweb refactoring yielded a clean point to wrap a function that could handle this, so I moved the routing for this out of the core. While not an hg wire protocol, this seems logically close enough. For now, these handlers do nothing other than check permissions. The protocol requires support for PUT requests, so that has been added to the core, and funnels into the same handler as GET and POST. The permission checking code was assuming that anything not checking 'pull' or None ops should be using POST. But that breaks the upload check if it checks 'push'. So I invented a new 'upload' permission, and used it to avoid the mandate to POST. A function wrap point could be added, but security code should probably stay grouped together. Given that anything not 'pull' or None was requiring POST, the comment on hgweb.common.permhooks is probably wrong- there is no 'read'. The rationale for the URIs is that the spec for the Batch API[1] defines the URL as the LFS server url + '/objects/batch'. The default git URLs are: Git remote: https://git-server.com/foo/bar LFS server: https://git-server.com/foo/bar.git/info/lfs Batch API: https://git-server.com/foo/bar.git/info/lfs/objects/batch '.git/' seems like it's not something a user would normally track. If we adhere to how git defines the URLs, then the hg-git extension should be able to talk to a git based server without any additional work. The URI for the transfer requests starts with '.hg/' to ensure that there are no conflicts with tracked files. Since these are handed out by the Batch API, we can change this at any point in the future. (Specifically, it might be a good idea to use something under the proposed /api/ namespace.) In any case, no files are stored at these locations in the repository directory. I started a new module for this because it seems like a good idea to keep all of the security sensitive server side code together. There's also an issue with `hg verify` in that it will want to download *all* blobs in order to run. Sadly, there's no way in the protocol to ask the server to verify the content of a blob it may have. (The verify action is for storing files on a 3rd party server, and then informing the LFS server when that completes.) So we may end up implementing a custom transfer adapter that simply indicates if the blobs are valid, and fall back to basic transfers for non-hg servers. In other words, this code is likely to get bigger before this is made non-experimental. [1] https://github.com/git-lfs/git-lfs/blob/master/docs/api/batch.md

     1

# wireprotolfsserver.py - lfs protocol server side implementation

     2

#

     3

# Copyright 2018 Matt Harbison <matt_harbison@yahoo.com>

     4

#

     5

# This software may be used and distributed according to the terms of the

     6

# GNU General Public License version 2 or any later version.

     7

     8

from __future__ import absolute_import

     9

    10

from mercurial.hgweb import (

    11

    common as hgwebcommon,

    12

)

    13

    14

from mercurial import (

    15

    pycompat,

    16

)

    17

    18

def handlewsgirequest(orig, rctx, req, res, checkperm):

    19

    """Wrap wireprotoserver.handlewsgirequest() to possibly process an LFS

    20

    request if it is left unprocessed by the wrapped method.

    21

    """

    22

    if orig(rctx, req, res, checkperm):

    23

        return True

    24

    25

    if not req.dispatchpath:

    26

        return False

    27

    28

    try:

    29

        if req.dispatchpath == b'.git/info/lfs/objects/batch':

    30

            checkperm(rctx, req, 'pull')

    31

            return _processbatchrequest(rctx.repo, req, res)

    32

        # TODO: reserve and use a path in the proposed http wireprotocol /api/

    33

        #       namespace?

    34

        elif req.dispatchpath.startswith(b'.hg/lfs/objects'):

    35

            return _processbasictransfer(rctx.repo, req, res,

    36

                                         lambda perm:

    37

                                                checkperm(rctx, req, perm))

    38

        return False

    39

    except hgwebcommon.ErrorResponse as e:

    40

        # XXX: copied from the handler surrounding wireprotoserver._callhttp()

    41

        #      in the wrapped function.  Should this be moved back to hgweb to

    42

        #      be a common handler?

    43

        for k, v in e.headers:

    44

            res.headers[k] = v

    45

        res.status = hgwebcommon.statusmessage(e.code, pycompat.bytestr(e))

    46

        res.setbodybytes(b'0\n%s\n' % pycompat.bytestr(e))

    47

        return True

    48

    49

def _processbatchrequest(repo, req, res):

    50

    """Handle a request for the Batch API, which is the gateway to granting file

    51

    access.

    52

    53

    https://github.com/git-lfs/git-lfs/blob/master/docs/api/batch.md

    54

    """

    55

    return False

    56

    57

def _processbasictransfer(repo, req, res, checkperm):

    58

    """Handle a single file upload (PUT) or download (GET) action for the Basic

    59

    Transfer Adapter.

    60

    61

    After determining if the request is for an upload or download, the access

    62

    must be checked by calling ``checkperm()`` with either 'pull' or 'upload'

    63

    before accessing the files.

    64

    65

    https://github.com/git-lfs/git-lfs/blob/master/docs/api/basic-transfers.md

    66

    """

    67

    68

    method = req.method

    69

    70

    if method == b'PUT':

    71

        checkperm('upload')

    72

    elif method == b'GET':

    73

        checkperm('pull')

    74

    75

    return False