changeset 52399:0c4832bf517a stable

contrib: propagate `pytype` failures outside of `check-pytype.sh` A recent series got landed with a pytype failure, because it wasn't propagated to the CI caller (see c47fe7fd312d). I suspect it started recently with 069735062524, because failures have been flagged in the past. The shebang line needs to be specific to bash, otherwise it ignores this non-POSIX extension. I'm not aware of a POSIX flavor of this option.
author Matt Harbison <matt_harbison@yahoo.com>
date Thu, 05 Dec 2024 23:58:28 -0500
parents 0851d94bfdaa
children 0030bb6864ca 64baff9f7dad
files contrib/check-pytype.sh contrib/heptapod-ci.yml
diffstat 2 files changed, 3 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/contrib/check-pytype.sh	Mon Nov 25 18:56:39 2024 -0500
+++ b/contrib/check-pytype.sh	Thu Dec 05 23:58:28 2024 -0500
@@ -1,7 +1,8 @@
-#!/bin/sh
+#!/bin/bash
 
 set -e
 set -u
+set -o pipefail
 
 cd "$(hg root)"
 
--- a/contrib/heptapod-ci.yml	Mon Nov 25 18:56:39 2024 -0500
+++ b/contrib/heptapod-ci.yml	Thu Dec 05 23:58:28 2024 -0500
@@ -442,7 +442,7 @@
       - ./contrib/setup-pytype.sh
     script:
       - echo "Entering script section"
-      - sh contrib/check-pytype.sh
+      - bash contrib/check-pytype.sh
 
 # `sh.exe --login` sets a couple of extra environment variables that are defined
 # in the MinGW shell, but switches CWD to /home/$username.  The previous value