style: use `ui.xxxnoi18n()` methods instead of wrapping msg in `()` These aliases were introduced back in 5209fc94b982, because `black` was going to strip away the extra parentheses, but they're needed to subvert `test-check-code.t`. That obviously changed at some point, but `pyupgrade`[1] also strips these out. While that tool is very useful in adapting code to modern standards, it lacks the ability to turn off most conversions, so constantly reverting these is a pain. Even without that, the code is more understandable with an explicit declaration. It also would have been an easy typo to miss the leading `_` in the i18n method `_()` that the checker is looking for, and fail to detect the problem. The `contrib/perf.py` code just uses a local alias to the original methods because (IIUC), this tries to be compatible with old versions of hg. But practically, these noi18n aliases were added before useful py3 support, and at some point, it won't be feasible to do py2 benchmarking anymore, and maybe this module can be cleaned up some. [1] https://github.com/asottile/pyupgrade

     1

# tiny extension to report phase changes during transaction

     2

     3

     4

def reposetup(ui, repo):

     5

    def reportphasemove(tr):

     6

        for revs, move in sorted(tr.changes[b"phases"], key=lambda r: r[0][0]):

     7

            for rev in revs:

     8

                if move[0] is None:

     9

                    ui.writenoi18n(

    10

                        b'test-debug-phase: new rev %d:  x -> %d\n'

    11

                        % (rev, move[1])

    12

                    )

    13

                else:

    14

                    ui.writenoi18n(

    15

                        b'test-debug-phase: move rev %d: %d -> %d\n'

    16

                        % (rev, move[0], move[1])

    17

                    )

    18

    19

    class reportphaserepo(repo.__class__):

    20

        def transaction(self, *args, **kwargs):

    21

            tr = super(reportphaserepo, self).transaction(*args, **kwargs)

    22

            tr.addpostclose(b'report-phase', reportphasemove)

    23

            return tr

    24

    25

    repo.__class__ = reportphaserepo